Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762414Ab2EQW4o (ORCPT ); Thu, 17 May 2012 18:56:44 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:59360 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758927Ab2EQW4m (ORCPT ); Thu, 17 May 2012 18:56:42 -0400 MIME-Version: 1.0 In-Reply-To: References: <1337292816-10839-1-git-send-email-hjl.tools@gmail.com> <1337292816-10839-2-git-send-email-hjl.tools@gmail.com> <4FB57EB2.4050208@zytor.com> From: Linus Torvalds Date: Thu, 17 May 2012 15:56:21 -0700 X-Google-Sender-Auth: QuuKmPxNVXbA_oPrxsJ5Mqtvyig Message-ID: Subject: Re: [PATCH 01/10] Use __kernel_long_t in struct timex To: "H. Peter Anvin" Cc: "H.J. Lu" , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 27 On Thu, May 17, 2012 at 3:50 PM, Linus Torvalds wrote: > > I think __word would be good too, *except* for the fact that > especially in x86 land, I think there's the legacy confusion with > "word" being 16-bit. Ugh. Looking at the x32 case, I have to say that "long" in general looks horrible. Especially when we have things like typedef long long __kernel_long_t; (and __long really wouldn't look any nicer). Any sane person would go "Eww" at looking at that - we're using 'long long' to typedef a type that is named 'long'. It would make much more sense to use "__word" for reasons like that. But I really don't think that works well in a x86 context. Other ideas? Maybe "__wordsize" would be less associated with x86 16-bit words? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/