Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933621Ab2ERAMK (ORCPT ); Thu, 17 May 2012 20:12:10 -0400 Received: from solo.fdn.fr ([80.67.169.19]:58037 "EHLO solo.fdn.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933557Ab2ERAMG (ORCPT ); Thu, 17 May 2012 20:12:06 -0400 Date: Fri, 18 May 2012 02:12:02 +0200 From: Samuel Thibault To: "Brandeburg, Jesse" Cc: "Dave, Tushar N" , "Kirsher, Jeffrey T" , "Allan, Bruce W" , "Wyborny, Carolyn" , "Skidmore, Donald C" , "Rose, Gregory V" , "Waskiewicz Jr, Peter P" , "Duyck, Alexander H" , "Ronciak, John" , "David S. Miller" , Jiri Pirko , Dean Nelson , "e1000-devel@lists.sourceforge.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] e1000: Reset rx ring index on receive overrun Message-ID: <20120518001202.GN683@type.famille.thibault.fr> Mail-Followup-To: Samuel Thibault , "Brandeburg, Jesse" , "Dave, Tushar N" , "Kirsher, Jeffrey T" , "Allan, Bruce W" , "Wyborny, Carolyn" , "Skidmore, Donald C" , "Rose, Gregory V" , "Waskiewicz Jr, Peter P" , "Duyck, Alexander H" , "Ronciak, John" , "David S. Miller" , Jiri Pirko , Dean Nelson , "e1000-devel@lists.sourceforge.net" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20120517230140.GZ683@type.famille.thibault.fr> <061C8A8601E8EE4CA8D8FD6990CEA891188439E0@ORSMSX102.amr.corp.intel.com> <20120517232821.GJ683@type.famille.thibault.fr> <20120517233124.GK683@type.famille.thibault.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1183 Lines: 28 Brandeburg, Jesse, le Thu 17 May 2012 17:04:04 -0700, a ?crit : > On Thu, 17 May 2012, Samuel Thibault wrote: > > > Samuel Thibault, le Fri 18 May 2012 01:28:21 +0200, a ?crit : > > > Dave, Tushar N, le Thu 17 May 2012 23:22:31 +0000, a ?crit : > > > > I am interested in to see if you have actual test case and more > > > > importantly test data that shows that kernel and device indexes are > > > > not synchronized any more. > > > > > > Well, it's not with an actual physical device, but with the kvm > > > emulation. > > > > BTW, it also happens easily when request_irq takes some time to > > complete: since we enable E1000_TCTL_EN before that, the card can have > > time to fill the ring before irqs are processed. > > I think there may well be a bug in the implementation in kvm. The > hardware doesn't have this bug. How does it avoid filling the ring? What is the purpose of the RXO flag if it does avoid them? Samuel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/