Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030918Ab2ERD4m (ORCPT ); Thu, 17 May 2012 23:56:42 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:33097 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966450Ab2ERD4X convert rfc822-to-8bit (ORCPT ); Thu, 17 May 2012 23:56:23 -0400 MIME-Version: 1.0 In-Reply-To: References: <1337292816-10839-1-git-send-email-hjl.tools@gmail.com> <1337292816-10839-9-git-send-email-hjl.tools@gmail.com> <4FB58EFD.7010302@zytor.com> <4FB5C050.9070805@kernel.org> Date: Thu, 17 May 2012 20:56:22 -0700 Message-ID: Subject: Re: [PATCH 08/10] Use __kernel_ulong_t in struct msqid64_ds From: "H.J. Lu" To: Linus Torvalds Cc: "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de, Paul Mundt Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 27 On Thu, May 17, 2012 at 8:49 PM, Linus Torvalds wrote: > On Thu, May 17, 2012 at 8:39 PM, H.J. Lu wrote: >> >> That will be wrong. ? __BITS_PER_LONG defines # bits of long >> as seen by kernel. ?We don't use it in user space. > > Yes you do. Exactly in that structure that Peter points to. *Exactly* > because that structure uses "long" instead of some fixed size. Which > will be different in user mode than in kernel mode. > > And if user mode doesn't use these headers at all, then we should stop > playing the insane games. > > ? ? ? ? ? ? ? ? ? ? Linus We need kernel headers for constants used in system calls. But I don't mind if kernel stops exporting data structures to user space. -- H.J. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/