Date: Fri, 18 May 2012 10:21:28 +0200 (CEST)
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Vinod Koul <vinod.koul@linux.intel.com>
cc: linux-kernel@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Paul Mundt <lethal@linux-sh.org>, linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/9 v3] dma: shdma: prepare for conversion to the shdma
 base library
In-Reply-To: <1337055832.16185.5362.camel@vkoul-udesk3>
Message-ID: <Pine.LNX.4.64.1205181017250.23140@axis700.grange>
References: <1336576161-27082-1-git-send-email-g.liakhovetski@gmx.de> 
 <1336576161-27082-3-git-send-email-g.liakhovetski@gmx.de>
 <1337055832.16185.5362.camel@vkoul-udesk3>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1758
Lines: 52

On Tue, 15 May 2012, Vinod Koul wrote:

> On Wed, 2012-05-09 at 17:09 +0200, Guennadi Liakhovetski wrote:
> > By placing an anonymous union at the top of struct sh_dmae_slave we can
> > transparently prepare all device and client drivers for the upcoming
> > shdma-base conversion.
> > 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > ---
> >  include/linux/sh_dma.h |    8 ++++++--
> >  1 files changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/sh_dma.h b/include/linux/sh_dma.h
> > index 425450b..e081e8e 100644
> > --- a/include/linux/sh_dma.h
> > +++ b/include/linux/sh_dma.h
> > @@ -10,12 +10,16 @@
> >  #ifndef SH_DMA_H
> >  #define SH_DMA_H
> >  
> > -#include <linux/list.h>
> >  #include <linux/dmaengine.h>
> > +#include <linux/list.h>
> > +#include <linux/shdma-base.h>
> >  
> >  /* Used by slave DMA clients to request DMA to/from a specific peripheral */
> >  struct sh_dmae_slave {
> > -	unsigned int			slave_id; /* Set by the platform */
> > +	union {
> > +		unsigned int		slave_id; /* Set by the platform */
> > +		struct shdma_slave	shdma_slave;
> again, this should be move to dma_slave_config

Same reasoning as in patch 1: I think such changes should be done 
separately.

> > +	};
> >  	struct device			*dma_dev; /* Set by the platform */
> >  	const struct sh_dmae_slave_config	*config;  /* Set by the driver */
> >  };

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/