Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762611Ab2ERJ47 (ORCPT ); Fri, 18 May 2012 05:56:59 -0400 Received: from s15943758.onlinehome-server.info ([217.160.130.188]:38614 "EHLO mail.x86-64.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762250Ab2ERJ45 (ORCPT ); Fri, 18 May 2012 05:56:57 -0400 Date: Fri, 18 May 2012 11:56:38 +0200 From: Borislav Petkov To: Ingo Molnar Cc: Borislav Petkov , Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List , Aristeu Rozanski , Doug Thompson , Steven Rostedt , Frederic Weisbecker , Ingo Molnar Subject: Re: [PATCH v24b] RAS: Add a tracepoint for reporting memory controller events Message-ID: <20120518095638.GA20215@aftab.osrc.amd.com> References: <1337287277-523-1-git-send-email-mchehab@redhat.com> <20120517214859.GA16777@aftab.osrc.amd.com> <20120518071244.GE429@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120518071244.GE429@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2329 Lines: 61 On Fri, May 18, 2012 at 09:12:44AM +0200, Ingo Molnar wrote: > > > Of course, any userspace tools meant to handle errors should not parse > > > the above data. They should, instead, use the binary fields provided by > > > the tracepoint, mapping them directly into their MIBs. > > > > Nacked-by: Borislav Petkov > > Just wondering why this got nacked, and what the > suggestions/plans are to improve the situation: Basically this is the thread which lead to it: http://marc.info/?l=linux-kernel&m=133709477524773&w=2 > I assume Mauro is working on these things to solve problems, or to > add features, Mauro could you please give a higher level list of > those problems or features? There must be more to it than just a new > tracepoint! :-) My main objection was that the tracepoint to report errors from edac contains the following prototype: + TP_PROTO(const unsigned int err_type, + const unsigned int mc_index, + const char *error_msg, + const char *label, + const char *location, + const char *core_detail, + const char *driver_detail), and that the last args should be merged simply into one 'const char *detail' which every driver can populate as it sees fit. But Mauro did not want to parse the string in userspace but feed it straight into a MIB (which could mean "Men In Black" for all I know), right from the tracepoint: > Of course, any userspace tools meant to handle errors should not parse > the above data. They should, instead, use the binary fields provided by > the tracepoint, mapping them directly into their MIBs. And I wanted to have a generic, usable-for-all tracepoint output which anyone in userspace can parse, decode, cut, paste as she sees fit without forcing kernel output formatting into any abstract error management hierarchy or whatever. As Tony put it, we need to hammer that out properly now before it becomes an ABI. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/