Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762673Ab2ERKJY (ORCPT ); Fri, 18 May 2012 06:09:24 -0400 Received: from merlin.infradead.org ([205.233.59.134]:56411 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757078Ab2ERKJW convert rfc822-to-8bit (ORCPT ); Fri, 18 May 2012 06:09:22 -0400 Message-ID: <1337335753.573.9.camel@twins> Subject: Re: [PATCH 1/2] perf: Add persistent event facilities From: Peter Zijlstra To: Borislav Petkov Cc: Frederic Weisbecker , Ingo Molnar , Steven Rostedt , LKML , Borislav Petkov Date: Fri, 18 May 2012 12:09:13 +0200 In-Reply-To: <1332340496-21658-2-git-send-email-bp@amd64.org> References: <1332340496-21658-1-git-send-email-bp@amd64.org> <1332340496-21658-2-git-send-email-bp@amd64.org> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 597 Lines: 15 On Wed, 2012-03-21 at 15:34 +0100, Borislav Petkov wrote: > + persistent : 1, /* always-on event */ Should creating something like that be privileged? And it looks like you allow creating persistent per-task events; is that useful, if so why? And like already pointed out, your cleanup seems broken in that case. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/