From: H Hartley Sweeten <hartleys@visionengravers.com>
To: Ian Abbott <abbotti@mev.co.uk>
CC: Ian Abbott <ian.abbott@mev.co.uk>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "fmhess@users.sourceforge.net" <fmhess@users.sourceforge.net>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Date: Fri, 18 May 2012 12:52:53 -0500
Subject: RE: [PATCH] staging: comedi: cleanup all the comedi_driver 'detach'
 functions
Thread-Topic: [PATCH] staging: comedi: cleanup all the comedi_driver
 'detach' functions
Thread-Index: Ac01HmnNH6uGuMGsTbqrDTc6Cox67QAAIGtg
Message-ID: <ADE657CA350FB648AAC2C43247A983F0020698AE12AE@AUSP01VMBX24.collaborationhost.net>
References: <201205171711.14968.hartleys@visionengravers.com>
 <4FB6230C.2080604@mev.co.uk>
 <ADE657CA350FB648AAC2C43247A983F0020698AE1272@AUSP01VMBX24.collaborationhost.net>
 <4FB68B57.7040404@mev.co.uk>
In-Reply-To: <4FB68B57.7040404@mev.co.uk>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1298
Lines: 35

On Friday, May 18, 2012 10:48 AM, Ian Abbott wrote:
> On 2012-05-18 17:56, H Hartley Sweeten wrote:
>> Can you test this patch and let me know what the resulting output
>> is? You may need to change the dev_dbg to dev_info or something
>> else if you don't have the proper kernel debugging enabled.
>
>> diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
>> index 1c3d638..d6bb1f9 100644
>> --- a/drivers/staging/comedi/drivers.c
>> +++ b/drivers/staging/comedi/drivers.c
>> @@ -91,11 +91,14 @@ static void cleanup_device(struct comedi_device *dev)
>>   static void __comedi_device_detach(struct comedi_device *dev)
>>   {
>>   	dev->attached = 0;
>> -	if (dev->driver)
>> +	if (dev->driver) {
>>   		dev->driver->detach(dev);
>> -	else
>> -		printk(KERN_WARNING
>> +		dev_dbg(dev->class_dev, "%s detached\n",
>> +			dev->driver->driver_name);
>> +	} else {
>> +		dev_warn(dev->class_dev,
>>   		       "BUG: dev->driver=NULL in comedi_device_detach()\n");
>> +	}
>>   	cleanup_device(dev);
>>   }
>
> It works, but I'd prefer dev_info over dev_dbg.

OK. What was the actual message output?

Thanks,
Hartley
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?