Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968095Ab2ERVsw (ORCPT ); Fri, 18 May 2012 17:48:52 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:49595 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968062Ab2ERVst (ORCPT ); Fri, 18 May 2012 17:48:49 -0400 Date: Fri, 18 May 2012 14:47:20 -0700 From: Anton Vorontsov To: Colin Cross Cc: Greg Kroah-Hartman , Kees Cook , Tony Luck , Arnd Bergmann , John Stultz , Shuah Khan , arve@android.com, Rebecca Schultz Zavin , Jesper Juhl , Randy Dunlap , Stephen Boyd , Thomas Meyer , Andrew Morton , Marco Stornelli , WANG Cong , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com Subject: Re: [PATCH v2 0/6] Merge ram_console into pstore Message-ID: <20120518214720.GA29976@lizard> References: <20120517083740.GA25627@lizard> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1082 Lines: 29 On Thu, May 17, 2012 at 11:42:29AM -0700, Colin Cross wrote: [...] > Other than my comment on logging console into a single record, > Acked-by: Colin Cross Thanks! > There is one feature that ram_console had but lost when I added > persistent_ram, which would be nice to get back: registering the > platform driver before module_init, to allow it to log oopses that > happen during device probing. This requires changing module_init to > postcore_initcall, and switching from platform_driver_probe to > platform_driver_register because the platform device is not registered > when the platform driver is registered. Depending on what functions > are __init, it may cause a cascading change from __init to __devinit > as well. Yep, I'll look into it. Thanks, -- Anton Vorontsov Email: cbouatmailru@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/