Date: Fri, 18 May 2012 14:56:17 -0700
From: Stephen Hemminger <shemminger@vyatta.com>
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1]net:ethernet:fixed a coding style issue relating
 space.
Message-ID: <20120518145617.710bc1d6@nehalam.linuxnetplumber.net>
In-Reply-To: <1337377537-4636-1-git-send-email-ahiliation@yahoo.co.in>
References: <1337377537-4636-1-git-send-email-ahiliation@yahoo.co.in>
Organization: Vyatta
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1136
Lines: 31

On Sat, 19 May 2012 03:15:37 +0530
Jeffrin Jose <ahiliation@yahoo.co.in> wrote:

> Fixed a coding style issue relating to  space found
> by checkpatch.pl tool in net/ethernet/eth.c
> 
> Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>
> ---
>  net/ethernet/eth.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
> index 36e5880..c847aa6 100644
> --- a/net/ethernet/eth.c
> +++ b/net/ethernet/eth.c
> @@ -178,7 +178,7 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
>  	 *      seems to set IFF_PROMISC.
>  	 */
>  
> -	else if (1 /*dev->flags&IFF_PROMISC */ ) {
> +	else if (1 /*dev->flags&IFF_PROMISC */) {
>  		if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
>  						      dev->dev_addr)))
>  			skb->pkt_type = PACKET_OTHERHOST;

Rather than put lips on a pig, why not remove the bogus if?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/