Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031068Ab2ERXje (ORCPT ); Fri, 18 May 2012 19:39:34 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:45671 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030314Ab2ERXjb (ORCPT ); Fri, 18 May 2012 19:39:31 -0400 From: Grant Likely Subject: Re: [PATCH] mfd: wm831x: Convert to irq_domain To: Mark Brown , Samuel Ortiz Cc: Anton Vorontsov , Dmitry Torokhov , Linus Walleij , patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, Liam Girdwood , Mark Brown In-Reply-To: <1336943936-27999-1-git-send-email-broonie@opensource.wolfsonmicro.com> References: <1336943936-27999-1-git-send-email-broonie@opensource.wolfsonmicro.com> Date: Fri, 18 May 2012 17:39:29 -0600 Message-Id: <20120518233929.75F8E3E07C8@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1801 Lines: 34 On Sun, 13 May 2012 22:18:56 +0100, Mark Brown wrote: > The modern idiom is to use irq_domain to allocate interrupts. This is > useful partly to allow further infrastructure to be based on the domains > and partly because it makes it much easier to allocate virtual interrupts > to devices as we don't need to allocate a contiguous range of interrupt > numbers. > > Convert the wm831x driver over to this infrastructure, using a legacy > IRQ mapping if an irq_base is specified in platform data and otherwise > using a linear mapping, always registering the interrupts even if they > won't ever be used. Only boards which need to use the GPIOs as > interrupts should need to use an irq_base. > > This means that we can't use the MFD irq_base management since the > unless we're using an explicit irq_base from platform data we can't rely > on a linear mapping of interrupts. Instead we need to map things via > the irq_domain - provide a conveniencem function wm831x_irq() to save a > small amount of typing when doing so. Looking at this I couldn't clearly > see anything the MFD core could do to make this nicer. > > Since we're not supporting device tree yet there's no meaningful > advantage if we don't do this conversion in one, the fact that the > interrupt resources are used for repeated IP blocks makes accessor > functions for the irq_domain more trouble to do than they're worth. > > Signed-off-by: Mark Brown Acked-by: Grant Likely -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/