Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968261Ab2ESAvg (ORCPT ); Fri, 18 May 2012 20:51:36 -0400 Received: from oproxy8-pub.bluehost.com ([69.89.22.20]:54791 "HELO oproxy8-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932764Ab2ESAve (ORCPT ); Fri, 18 May 2012 20:51:34 -0400 Message-ID: <4FB6EE9D.8010103@xenotime.net> Date: Fri, 18 May 2012 17:51:41 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110323 Thunderbird/3.1.9 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: Stephen Rothwell , linux-next@vger.kernel.org, LKML , Ian Abbott , Frank Mori Hess , devel@driverdev.osuosl.org Subject: Re: [PATCH -next] comedi: fix build when USB is not enabled References: <20120518184943.2c762e8441e53ea24748d1b8@canb.auug.org.au> <4FB6ED55.6090805@xenotime.net> <20120519005031.GA27613@kroah.com> In-Reply-To: <20120519005031.GA27613@kroah.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 30 On 05/18/2012 05:50 PM, Greg Kroah-Hartman wrote: > On Fri, May 18, 2012 at 05:46:13PM -0700, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Calls to optional subsystems cannot be made indiscriminately. >> Enclose all of the usb helper functions inside >> #if IS_ENABLED(CONFIG_USB) >> to fix these build errors. >> >> (The pci helper functions are OK since there are stubs in >> linux/pci.h for the called functions when PCI is not enabled. >> Possibly the same could be done for the called USB functions.) >> >> ERROR: "usb_deregister" [drivers/staging/comedi/comedi.ko] undefined! >> ERROR: "usb_register_driver" [drivers/staging/comedi/comedi.ko] undefined! > > I would rather stub these out in usb.h instead, care to make a patch for > that? I'll see how that goes... -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/