Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759959Ab2ESLAi (ORCPT ); Sat, 19 May 2012 07:00:38 -0400 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:65384 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758397Ab2ESLAh (ORCPT ); Sat, 19 May 2012 07:00:37 -0400 Message-ID: <1337425233.2041.17.camel@koala> Subject: Re: [PATCH v3] UBIFS: read crypto_lookup from datanodes to znodes From: Artem Bityutskiy To: Joel Reardon Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Date: Sat, 19 May 2012 14:00:33 +0300 In-Reply-To: References: <1337087022.2528.204.camel@sauron.fi.intel.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-M50YmhQPM/FBi1MAemzZ" X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1888 Lines: 52 --=-M50YmhQPM/FBi1MAemzZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2012-05-19 at 10:30 +0200, Joel Reardon wrote: > + crypto_lookup =3D le64_to_cpu(dn->crypto_lookup); > + if (zbr->crypto_lookup !=3D 0) > + ubifs_assert(zbr->crypto_lookup =3D=3D > + crypto_lookup); This "crypto_lookup" name is too long. Would you mind if we re-name it to "ksa_pos" instead (KSA position)? Then we'll wrap less lines. We can do this as a separate patch on top of this one. How does this sound to you? --=20 Best Regards, Artem Bityutskiy --=-M50YmhQPM/FBi1MAemzZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAABAgAGBQJPt31RAAoJECmIfjd9wqK0lfYP/icetYjBKbQqms+TYZlBY/Gx hl4rTLyuEn+fPPvmvLiY6PvVkrk6kX4mDGh1Bq058Gn0VwWa99NkhsxP4/n4Dis6 4pQzI5hxsy3Z5DYPXKQMPWf5w2ICHebN2dWnk/gWEF5lK9B4DBwXYWPItBQsLo3x m2xlJuj7/QDEyYUjiJqr8kKS9K9w+oTv51wdIz7jBxspt3PtvFlW2nZyOpoR8+02 1MQX0javr4PhEZGzpf/V8omls3NvBj1JLKlHt770kGWWIRPgfOas6rEXKR3MLucO cNe3UUSPdxN2TXHXiMNkizWvf80jfYis6w7QMb04fK5fKyHQ1fCDm/OBrS9jZhWj BihKYxldSyVWCB5ZgbfqqQGpluEnntnJDX7jNRlmUBEbNxdPKffogmAJI+VSaL5h UiKZTnCQCNZIKdG/DUoVTtCvNuGxQogPoecf+tx69v1nRR3Ain83xAm6hMQc5Tgy YHRDBGQA2tFTmK9rVgWjpgfZTJoWMpVX/EpIG65VLjpqqwWawLhH77gkVexSxJw+ fcDwselj98MSPbM62REk4Skhk5FPkDJz2e+Tyw2JsMBkLPhr191XEaOTaaoettaG Fd01FO+O4YG2FuwkRm8KVa6z/0o7wySC7oAgjApRNlO1osNz23qyVKRznLfPbnHo 1OhSJI9WExYjMrq4tXWP =O5HV -----END PGP SIGNATURE----- --=-M50YmhQPM/FBi1MAemzZ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/