Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760581Ab2ESOrA (ORCPT ); Sat, 19 May 2012 10:47:00 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:50102 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760389Ab2ESOq5 (ORCPT ); Sat, 19 May 2012 10:46:57 -0400 Date: Sat, 19 May 2012 07:46:52 -0700 From: Greg KH To: Christoph Biedl Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Sami Liedes , Tejun Heo , Christoph Lameter , Catalin Marinas Subject: Re: [ 31/54] kmemleak: Fix the kmemleak tracking of the percpu areas with !SMP Message-ID: <20120519144652.GA2067@kroah.com> References: <20120518212656.GA4992@kroah.com> <20120518211602.287791770@linuxfoundation.org> <1337433313@msgid.manchmal.in-ulm.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1337433313@msgid.manchmal.in-ulm.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1412 Lines: 40 On Sat, May 19, 2012 at 03:27:33PM +0200, Christoph Biedl wrote: > Greg KH wrote... > > > 3.0-stable review patch. If anyone has any objections, please let me know. > > > From: Catalin Marinas > > > > commit 100d13c3b5b9410f604b86f5e0a34da64b8cf659 upstream. > > > + /* kmemleak tracks the percpu allocations separately */ > > + kmemleak_free(fc); > > That one causes: > > mm/percpu.c: In function ‘setup_per_cpu_areas’: > mm/percpu.c:1877: error: implicit declaration of function ‘kmemleak_free’ > make[1]: *** [mm/percpu.o] Error 1 > make: *** [mm] Error 2 Odd, it doesn't cause that problem here for me, what ARCH are you building for? I'm on x86-64. > Trivial fix, works for me: Add > > #include > > to mm/percpu.c. FWIW, upstream did this in in f528f0b but I cannot > tell whether that commit is in any way of interest for 3.0.x. Actually, I don't think this is needed at all for 3.0 as percpu memleak handling went in with the patch you reference above, so this would cause problems on 3.0. So I'll go delete that patch from the queue, thanks for letting me know. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/