Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751498Ab2ETF05 (ORCPT ); Sun, 20 May 2012 01:26:57 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:38488 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750984Ab2ETF0z (ORCPT ); Sun, 20 May 2012 01:26:55 -0400 From: Grant Likely Subject: Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs. To: David Daney , Shubhrajyoti Datta Cc: David Daney , devicetree-discuss@lists.ozlabs.org, Rob Herring , spi-devel-general@lists.sourceforge.net, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org In-Reply-To: <4FB14B55.4070604@gmail.com> References: <1336772086-17248-1-git-send-email-ddaney.cavm@gmail.com> <1336772086-17248-3-git-send-email-ddaney.cavm@gmail.com> <4FB14B55.4070604@gmail.com> Date: Sat, 19 May 2012 23:26:53 -0600 Message-Id: <20120520052653.590673E03B8@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 966 Lines: 27 On Mon, 14 May 2012 11:13:41 -0700, David Daney wrote: > On 05/13/2012 10:46 PM, Shubhrajyoti Datta wrote: > > Hi David, > > A few comments. > > > > On Sat, May 12, 2012 at 3:04 AM, David Daney wrote: > [...] > > >> + > >> +#define DRV_VERSION "2.0" /* Version 1 was the out-of-tree driver */ > > This could be given a miss. As it is less meaningful once accepted. > > > Well, this leads to the question, what is the purpose of the > 'MODULE_VERSION()' macro? If I use that, I need to populate it with a > value. Don't use MODULE_VERSION. Just because it is there doesn't mean you need to use it. :-) You'll notice that none of the other spi drivers have it. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/