Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752164Ab2ETGIH (ORCPT ); Sun, 20 May 2012 02:08:07 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:34078 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751999Ab2ETGIE (ORCPT ); Sun, 20 May 2012 02:08:04 -0400 From: Grant Likely Subject: Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node(). To: David Daney , devicetree-discuss@lists.ozlabs.org, Rob Herring , spi-devel-general@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-doc@vger.kernel.org, David Daney , Liam Girdwood , Timur Tabi , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org In-Reply-To: <20120520055436.13AF03E03B8@localhost> References: <1336773923-17866-1-git-send-email-ddaney.cavm@gmail.com> <1336773923-17866-2-git-send-email-ddaney.cavm@gmail.com> <20120520055436.13AF03E03B8@localhost> Date: Sun, 20 May 2012 00:08:01 -0600 Message-Id: <20120520060802.03CE73E03B8@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1996 Lines: 48 On Sat, 19 May 2012 23:54:36 -0600, Grant Likely wrote: > On Fri, 11 May 2012 15:05:21 -0700, David Daney wrote: > > From: David Daney > > > > When generating MODALIASes, it is convenient to add things like "spi:" > > or "i2c:" to the front of the strings. This allows the standard > > modprobe to find the right driver when automatically populating bus > > children from the device tree structure. > > > > Add a prefix parameter, and adjust callers. For > > of_register_spi_devices() use the "spi:" prefix. > > > > Signed-off-by: David Daney > > Applied, thanks. Some notes below... Wait... why is this necessary? The module type prefix isn't stored in the modalias value for any other bus type as far as I can see, and with this series it appears that the "spi:" prefix may or may not be present in the modalias. That doesn't look right. Why isn't prefixing spi: at uevent time sufficient? IIUC, modprobe depends on either UEVENT or the modalias attribute to know which driver to probe. It does look like the attribute is missing the spi: prefix though. Does the following change work instead of these two patches? diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 3d8f662..da8aac7 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -51,7 +51,7 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf) { const struct spi_device *spi = to_spi_device(dev); - return sprintf(buf, "%s\n", spi->modalias); + return sprintf(buf, "%s%s\n", SPI_MODULE_PREFIX, spi->modalias); } So, I've dropped this patch from my tree. If the change above works for you then I'll push it out. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/