Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753030Ab2ETJh7 (ORCPT <rfc822;w@1wt.eu>);
	Sun, 20 May 2012 05:37:59 -0400
Received: from mail-ob0-f174.google.com ([209.85.214.174]:35373 "EHLO
	mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752346Ab2ETJh5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 20 May 2012 05:37:57 -0400
MIME-Version: 1.0
In-Reply-To: <CAMO-S2g9fkg_KH0CPOsB_7GQTN2mu8zir+UZDp6=VC+7XDrfrg@mail.gmail.com>
References: <1337268092-6765-1-git-send-email-h.mitake@gmail.com>
	<4FB52636.3040604@linux.intel.com>
	<CAMO-S2g9fkg_KH0CPOsB_7GQTN2mu8zir+UZDp6=VC+7XDrfrg@mail.gmail.com>
Date: Sun, 20 May 2012 18:37:57 +0900
Message-ID: <CAMO-S2gyzK3VTQcTRw+FAO9ui_gy=1z=MVxUYM9sPN51KrDgkg@mail.gmail.com>
Subject: Re: [PATCH] perf bench: add new benchmark subsystem and suite "futex wait"
From: Hitoshi Mitake <h.mitake@gmail.com>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Paul Mackerras <paulus@samba.org>,
        Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
        Michel Lespinasse <walken@google.com>,
        Rusty Russell <rusty@rustcorp.com.au>,
        Eric Dumazet <eric.dumazet@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2021
Lines: 50

On Sun, May 20, 2012 at 5:32 PM, Hitoshi Mitake <h.mitake@gmail.com> wrote:
> On Fri, May 18, 2012 at 1:24 AM, Darren Hart <dvhart@linux.intel.com> wrote:
>> On 05/17/2012 08:21 AM, Hitoshi Mitake wrote:
>>> Hi Ingo, Eric and Darren,
>>> (CCed perf and futex folks)
>>>
>>> I wrote this patch for adding new subsystem "futex" and its suite "wait" to perf
>>> bench on tip/master. This is based on futextest by Darren Hart.
>>>
>>> Could you allow me to import your source code of futextest to perf bench, Darren?
>>>
>>
>> I do have some concerns I'd like to address first.
>>
>> What is advantage of incorporating this into perf as opposed to running
>> it with perf?
>
> The main and direct advantage is that perf bench can share useful
> utilities stored under tools/perf/util/ directory e.g. parse-options[ch].
>

BTW, I often feel parse-options.[ch] of perf (this was come from git,
right?) is very useful not only for perf and git but also other
projects. So I think these stuff are worth independence as a
library. If the library contains unified feature for parsing and
evaluating configuration files, the hell of managing configurable
options will be reduced. e.g. I often use "strace -e open <command>"
to detect configuration files read by the <command>...

I thought that if perf bench can be independent from perf with such
efforts, it can be smaller sized and statically linked binary. From my
experience, this will be good for embedded systems people.

This independence also has risk: less people can find it or is
attracted even if it stays in the kernel tree (e.g. tools/bench/). But
it seems that very few people know about perf bench, so this will not
be a serious problem ;)

I'd like to hear your opinion.

Thanks,

-- 
Hitoshi Mitake
h.mitake@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/