Date: Sun, 20 May 2012 15:19:08 +0200
From: Samuel Ortiz <sameo@linux.intel.com>
To: Johan Hovold <jhovold@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mfd: lm3533: fix return type of attribute is_visible
Message-ID: <20120520131908.GV12015@sortiz-mobl>
References: <1336725641-11826-1-git-send-email-jhovold@gmail.com>
 <20120518111804.GA20467@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120518111804.GA20467@localhost>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1519
Lines: 42

Hi Johan,

On Fri, May 18, 2012 at 01:18:04PM +0200, Johan Hovold wrote:
> Hi Samuel,
> 
> On Fri, May 11, 2012 at 10:40:41AM +0200, Johan Hovold wrote:
> > Since commit 587a1f1659 ("switch ->is_visible() to returning umode_t")
> > the return type of is_visible is umode_t rather than mode_t.
> > 
> > This silences a compiler warning on some architectures where these types
> > are not compatible.
> > 
> > Reported-by: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Johan Hovold <jhovold@gmail.com>
> > ---
> 
> Apparently Dan Carpenter sent a fix for this compiler warning the day
> after I submitted mine. Dan's patch, however, only fixed the return type
> and not the type of the mode variable.
> 
> Could you consider applying this patch one on top of Dan's (which you
> applied to mfd-next on Monday)?
I applied the following chunk:

@@ -367,7 +367,7 @@ static umode_t lm3533_attr_is_visible(struct kobject *kobj,
        struct device_attribute *dattr = to_dev_attr(attr);
        struct lm3533_device_attribute *lattr = to_lm3533_dev_attr(dattr);
        enum lm3533_attribute_type type = lattr->type;
-       mode_t mode = attr->mode;
+       umode_t mode = attr->mode;

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/