Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754730Ab2EUGmP (ORCPT ); Mon, 21 May 2012 02:42:15 -0400 Received: from LGEMRELSE6Q.lge.com ([156.147.1.121]:50452 "EHLO LGEMRELSE6Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467Ab2EUGmO convert rfc822-to-8bit (ORCPT ); Mon, 21 May 2012 02:42:14 -0400 X-AuditID: 9c930179-b7bb9ae000000ea5-c8-4fb9e3c3be40 From: Namhyung Kim To: Ingo Molnar Cc: Frederic Weisbecker , LKML , Steven Rostedt , Thomas Gleixner , Peter Zijlstra , Arnaldo Carvalho de Melo , Borislav Petkov , Jiri Olsa , Arun Sharma , Michael Rubin , David Sharp , Vaibhav Nagarnaik , Julia Lawall , Tom Zanussi , David Ahern Subject: Re: [PATCH 00/15] tools: Unify perf and trace-cmd trace event format parsing v3 References: <1335356819-16710-1-git-send-email-fweisbec@gmail.com> <20120507081424.GE16608@gmail.com> Date: Mon, 21 May 2012 15:40:04 +0900 In-Reply-To: <20120507081424.GE16608@gmail.com> (Ingo Molnar's message of "Mon, 7 May 2012 10:14:24 +0200") Message-ID: <87ehqe2g1n.fsf@sejong.aot.lge.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1785 Lines: 43 Hi, Ingo On Mon, 7 May 2012 10:14:24 +0200, Ingo Molnar wrote: > * Frederic Weisbecker wrote: >> This is essentially a rebase against latest tip:perf/core updates. >> Mostly due to conflicts against the perf Makefile updates. >> >> I think we all agree that this library needs improvements but these >> should rather be done incrementally. The current perf trace event parsing >> is anyway much backward compared to that library. >> >> Default target is a static library in tools/lib/traceevent/libtraceevent.a >> >> This can be pulled from: >> >> git://github.com/fweisbec/tracing.git >> perf/parse-events-4 > > It gives me: > > /home/mingo/tip/tools/lib/traceevent/parse-filter.c: In function ‘create_arg_item’: > /home/mingo/tip/tools/lib/traceevent/parse-filter.c:343:9: warning: comparison between ‘enum filter_arg_type’ and ‘enum event_type’ [-Wenum-compare] > /home/mingo/tip/tools/lib/traceevent/parse-filter.c:339:2: warning: case value ‘8’ not in enumerated type ‘enum filter_arg_type’ [-Wswitch] > > Had this been in tools/perf/ it would use -Werror already and > you'd have fixed it, not requiring me to unpull these bits :-/ > > So can we please make a libevent.so, built sanely within > tools/perf/lib/ or such and distributed together with perf so > that the two can never get out of sync? > So what are you gonna do with this patchset? If you merge this series, I can back-port latest changes on trace-cmd and do my further work like 'die' removal on it. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/