Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756401Ab2EUN3D (ORCPT ); Mon, 21 May 2012 09:29:03 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56081 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751864Ab2EUN3A (ORCPT ); Mon, 21 May 2012 09:29:00 -0400 Date: Mon, 21 May 2012 15:28:50 +0200 (CEST) From: Jiri Kosina To: David Rientjes Cc: Przemo Firszt , pinglinux@gmail.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linuxwacom-devel@lists.sourceforge.net Subject: Re: [PATCH] HID: wacom: Add LED selector control for Wacom Intuos4 WL In-Reply-To: Message-ID: References: <1336674232-5410-1-git-send-email-przemo@firszt.eu> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2235 Lines: 63 On Sat, 19 May 2012, David Rientjes wrote: > On Fri, 11 May 2012, Jiri Kosina wrote: > > > > Add sysfs attribute to control LED selector on Wacom Intuos4. > > > > Applied, thanks. > > > > This results in a build failure if you've enabled CONFIG_HID_WACOM without > CONFIG_NEW_LEDS, which is required for CONFIG_LEDS_CLASS. > > drivers/built-in.o: In function `led_classdev_unregister': > (.text+0x3ff685): undefined reference to `led_brightness_set' > drivers/built-in.o: In function `led_classdev_unregister': > (.text+0x3ff695): undefined reference to `leds_list_lock' > drivers/built-in.o: In function `led_classdev_unregister': > (.text+0x3ff6ab): undefined reference to `leds_list_lock' > drivers/built-in.o: In function `led_classdev_register': > (.text+0x3ff6e9): undefined reference to `leds_list_lock' > drivers/built-in.o: In function `led_classdev_register': > (.text+0x3ff6f5): undefined reference to `leds_list' > drivers/built-in.o: In function `led_classdev_register': > (.text+0x3ff700): undefined reference to `leds_list' > drivers/built-in.o: In function `led_classdev_register': > (.text+0x3ff70c): undefined reference to `leds_list_lock' > > Please apply the patch below. > > > hid, wacom: fix build breakage without CONFIG_LEDS_CLASS > > CONFIG_HID_WACOM must depend on CONFIG_LEDS_CLASS, otherwise > CONFIG_NEW_LEDS may be disabled. > > Signed-off-by: David Rientjes > --- > drivers/hid/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -613,8 +613,8 @@ config THRUSTMASTER_FF > config HID_WACOM > tristate "Wacom Bluetooth devices support" > depends on BT_HIDP > + depends on LEDS_CLASS > select POWER_SUPPLY > - select LEDS_CLASS > ---help--- > Support for Wacom Graphire Bluetooth and Intuos4 WL tablets. Right, thanks for your report. Now queued. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/