Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755963Ab2EUQMI (ORCPT ); Mon, 21 May 2012 12:12:08 -0400 Received: from g5t0008.atlanta.hp.com ([15.192.0.45]:26788 "EHLO g5t0008.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754564Ab2EUQMG (ORCPT ); Mon, 21 May 2012 12:12:06 -0400 Message-ID: <1337616723.2558.10.camel@lorien2> Subject: Re: [PATCH] ARM: leds: Add MAX6956 driver From: Shuah Khan Reply-To: shuah@fc.hp.com To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Cc: Bryan Wu , Richard Purdie , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Date: Mon, 21 May 2012 10:12:03 -0600 In-Reply-To: <20120521082626.GG3710@pengutronix.de> References: <1337355945-16421-1-git-send-email-u.kleine-koenig@pengutronix.de> <20120521082626.GG3710@pengutronix.de> Organization: ISS-VC Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 8bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 574 Lines: 17 On Mon, 2012-05-21 at 10:26 +0200, Uwe Kleine-König wrote: > > As Shuah said, no kfree(ddata) here > As Sascha said, it would be wrong to add one. Thanks. Didn't realize devm_* take care of free at device detach. I am starting to see patches that make this change to other leds drivers. Something new to learn. :) -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/