Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932425Ab2EUWIZ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 21 May 2012 18:08:25 -0400
Received: from mail-bk0-f46.google.com ([209.85.214.46]:54851 "EHLO
	mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932077Ab2EUWIX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 21 May 2012 18:08:23 -0400
Date: Tue, 22 May 2012 00:08:16 +0200
From: Andi Shyti <andi.shyti@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: Samuel Ortiz <sameo@linux.intel.com>, Felipe Balbi <balbi@ti.com>,
        Anton Vorontsov <cbou@mail.ru>, David Woodhouse <dwmw2@infradead.org>,
        Grazvydas Ignotas <notasas@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH 3/4] power_supply/MFD: twl4030_charger: Allow charger to
 control the regulator that feeds it.
Message-ID: <20120521220816.GA4346@andi>
Mail-Followup-To: NeilBrown <neilb@suse.de>,
	Samuel Ortiz <sameo@linux.intel.com>, Felipe Balbi <balbi@ti.com>,
	Anton Vorontsov <cbou@mail.ru>,
	David Woodhouse <dwmw2@infradead.org>,
	Grazvydas Ignotas <notasas@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	Tero Kristo <t-kristo@ti.com>
References: <20120508213518.2844.95446.stgit@notabene.brown>
 <20120508214040.2844.5662.stgit@notabene.brown>
 <20120513181208.GA2641@andi>
 <20120518124651.39af8eeb@notabene.brown>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120518124651.39af8eeb@notabene.brown>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1841
Lines: 64

Hi Neil,

On Fri, May 18, 2012 at 12:46:51PM +1000, NeilBrown wrote:
> On Sun, 13 May 2012 20:12:08 +0200 Andi Shyti <andi.shyti@gmail.com> wrote:
> 
> > Hi Neil,
> > 
> > On Wed, May 09, 2012 at 07:40:40AM +1000, NeilBrown wrote:
> > > @@ -183,6 +186,12 @@ static int twl4030_charger_enable_usb(struct twl4030_bci *bci, bool enable)
> > >  			return -EACCES;
> > >  		}
> > >  
> > > +		/* Need to keep regulator on */
> > > +		if (!bci->usb_enabled) {
> > > +			regulator_enable(bci->usb_reg);
> > 
> > Should you consider here a failure case?
> 
> Probably.  Something like this?
> 
> +		/* Need to keep regulator on */
> +		if (!bci->usb_enabled &&
> +		    bci->usb_reg &&
> +		    regulator_enable(bci->usb_reg) == 0)
> +			bci->usb_enabled = 1;
> +

maybe you could write it a bit nicer :)

> 
> > 
> > > +			bci->usb_enabled = 1;
> > > +		}
> > > +
> > >  		/* forcing the field BCIAUTOUSB (BOOT_BCI[1]) to 1 */
> > >  		ret = twl4030_clear_set_boot_bci(0, TWL4030_BCIAUTOUSB);
> > >  		if (ret < 0)
> > > @@ -511,6 +524,8 @@ static int __init twl4030_bci_probe(struct platform_device *pdev)
> > >  	bci->usb.num_properties = ARRAY_SIZE(twl4030_charger_props);
> > >  	bci->usb.get_property = twl4030_bci_get_property;
> > >  
> > > +	bci->usb_reg = regulator_get(bci->dev, "bci3v1");
> > 
> > ... and here.
> 
> In what circumstances can that fail, I wonder.
> Still, maybe this is best:
> 
> 
> +	bci->usb_reg = regulator_get(bci->dev, "bci3v1");
> +	if (IS_ERR(bci->usb_reg)) {
> +		dev_warn(&bci->dev, "regulator get bci3v1 failed\n");
> +		bci->usb_reg = NULL;
> +	}
> +

Yep!

Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/