Subject: Re: [PATCH 3/3][RFC] x86: x2apic/cluster: Do not handle cpumask
 allocation errors
From: Suresh Siddha <suresh.b.siddha@intel.com>
Reply-To: Suresh Siddha <suresh.b.siddha@intel.com>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
        Cyrill Gorcunov <gorcunov@openvz.org>, Yinghai Lu <yinghai@kernel.org>
Date: Mon, 21 May 2012 17:19:18 -0700
In-Reply-To: <20120518102659.GC31517@dhcp-26-207.brq.redhat.com>
References: <20120518102659.GC31517@dhcp-26-207.brq.redhat.com>
Organization: Intel Corp
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Message-ID: <1337645958.1997.172.camel@sbsiddha-desk.sc.intel.com>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 668
Lines: 19

On Fri, 2012-05-18 at 12:26 +0200, Alexander Gordeev wrote:
> With this fix allocations of cpumasks are assumed always successfull
> and possible failures result in BUG().

BUG check for memory allocation failures in IPI path is not a good idea.
We will be using IPI's to flush TLB's before we evict the pages for
recovering from low-memory conditions.  We need to provide a clean fall
back path.

So NAK.

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/