Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759356Ab2EVPYg (ORCPT ); Tue, 22 May 2012 11:24:36 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:39103 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754086Ab2EVPYe convert rfc822-to-8bit (ORCPT ); Tue, 22 May 2012 11:24:34 -0400 MIME-Version: 1.0 In-Reply-To: <1337696279-8994-1-git-send-email-anton.vorontsov@linaro.org> References: <20120522141717.GA31574@lizard> <1337696279-8994-1-git-send-email-anton.vorontsov@linaro.org> Date: Tue, 22 May 2012 08:24:33 -0700 X-Google-Sender-Auth: 2QUn5-gefr3m-v4d2uegYWsBUPM Message-ID: Subject: Re: [PATCH 01/16] pstore/inode: Make pstore_fill_super() static From: Kees Cook To: Anton Vorontsov Cc: Greg Kroah-Hartman , Colin Cross , Tony Luck , Arnd Bergmann , John Stultz , Shuah Khan , arve@android.com, Rebecca Schultz Zavin , Jesper Juhl , Randy Dunlap , Stephen Boyd , Thomas Meyer , Andrew Morton , Marco Stornelli , WANG Cong , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 688 Lines: 21 On Tue, May 22, 2012 at 7:17 AM, Anton Vorontsov wrote: > There's no reason to extern it. The patch fixes the annoying sparse > warning: > > CHECK ? fs/pstore/inode.c > fs/pstore/inode.c:264:5: warning: symbol 'pstore_fill_super' was not > declared. Should it be static? > > Signed-off-by: Anton Vorontsov Acked-by: Kees Cook -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/