Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756282Ab2EVXCN (ORCPT ); Tue, 22 May 2012 19:02:13 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:57998 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748Ab2EVXCL convert rfc822-to-8bit (ORCPT ); Tue, 22 May 2012 19:02:11 -0400 MIME-Version: 1.0 In-Reply-To: <4FBC1807.4050402@gmail.com> References: <1336773923-17866-1-git-send-email-ddaney.cavm@gmail.com> <1336773923-17866-2-git-send-email-ddaney.cavm@gmail.com> <20120520055436.13AF03E03B8@localhost> <20120520060802.03CE73E03B8@localhost> <4FBBECC2.10503@gmail.com> <4FBC1807.4050402@gmail.com> From: Grant Likely Date: Tue, 22 May 2012 17:01:51 -0600 X-Google-Sender-Auth: VJ0DlmJCvobI3s5mjMIFbn7aKyk Message-ID: Subject: Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node(). To: David Daney Cc: "devicetree-discuss@lists.ozlabs.org" , Rob Herring , "spi-devel-general@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "linux-mips@linux-mips.org" , "linux-doc@vger.kernel.org" , Liam Girdwood , Tabi Timur-B04825 , Mark Brown , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linuxppc-dev@lists.ozlabs.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1868 Lines: 69 Cool, thanks. g. On Tue, May 22, 2012 at 4:49 PM, David Daney wrote: > On 05/22/2012 01:09 PM, Grant Likely wrote: >> >> On Tue, May 22, 2012 at 1:45 PM, David Daney >> ?wrote: >>> >>> On 05/19/2012 11:08 PM, Grant Likely wrote: >>>> >>>> >>>> On Sat, 19 May 2012 23:54:36 -0600, Grant >>>> Likely ? ?wrote: >>>>> >>>>> >>>>> On Fri, 11 May 2012 15:05:21 -0700, David Daney >>>>> ?wrote: >>>>>> >>>>>> >>>>>> From: David Daney >>>>>> >>>>>> When generating MODALIASes, it is convenient to add things like "spi:" >>>>>> or "i2c:" to the front of the strings. ?This allows the standard >>>>>> modprobe to find the right driver when automatically populating bus >>>>>> children from the device tree structure. >>>>>> >>>>>> Add a prefix parameter, and adjust callers. ?For >>>>>> of_register_spi_devices() use the "spi:" prefix. >>>>>> >>>>>> Signed-off-by: David Daney >>>>> >>>>> >>>>> >>>>> Applied, thanks. ?Some notes below... >>>> >>>> >>>> >>>> Wait... why is this necessary? >>> >>> >>> >>> Because in of_register_spi_devices() in of_spi.c, you do: >>> >>> ? ? ? ?request_module(spi->modalias); >>> >>> The string passed to request_module() must have the "spi:" prefix. >> >> >> How about modifying the call to request_module() to include the prefix >> also? ?I think that would be a simpler change overall. ?Would that >> work? > > > It seems to. ?I just sent such a patch in a new thread. > > David Daney -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/