Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965089Ab2EWDkE (ORCPT ); Tue, 22 May 2012 23:40:04 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:60513 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964911Ab2EWDkC convert rfc822-to-8bit (ORCPT ); Tue, 22 May 2012 23:40:02 -0400 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "'gregkh@linuxfoundation.org'" , "Du, ChangbinX" Cc: "'David Rientjes'" , "'Sergei Shtylyov'" , "Fleming, Matt" , "'balbi@ti.com'" , "'hpa@zytor.com'" , "'linux-kernel@vger.kernel.org'" , "'linux-usb@vger.kernel.org'" Subject: Re: [PATCH v2] testusb: expose looping forever option "l" to user References: <0C18FE92A7765D4EB9EE5D38D86A563A063D03@SHSMSX101.ccr.corp.intel.com> Date: Tue, 22 May 2012 20:39:58 -0700 MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: "Michal Nazarewicz" Message-ID: In-Reply-To: <0C18FE92A7765D4EB9EE5D38D86A563A063D03@SHSMSX101.ccr.corp.intel.com> User-Agent: Opera Mail/11.64 (Linux) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2536 Lines: 68 On Tue, 22 May 2012 19:43:05 -0700, Du, ChangbinX wrote: > The testusb.c tool has support for looping forever implemented, which > may be useful for stress test, yet it is not exposed to the user, so > even though the code is there, it cannot be used. This commit adds > "l" to the set of options handled by the application which enables > the feature. > > Also, I collate help information for each command line option to make > it easier to use for novice. > > Signed-off-by: Du Changbin Acked-by: Michal Nazarewicz > --- > tools/usb/testusb.c | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c > index 0aac3ff..7a7adf3 100644 > --- a/tools/usb/testusb.c > +++ b/tools/usb/testusb.c > @@ -422,7 +422,7 @@ int main (int argc, char **argv) > /* for easy use when hotplugging */ > device = getenv ("DEVICE"); >- while ((c = getopt (argc, argv, "D:aA:c:g:hns:t:v:")) != EOF) > + while ((c = getopt (argc, argv, "D:aA:c:g:hlns:t:v:")) != EOF) > switch (c) { > case 'D': /* device, if only one */ > device = optarg; > @@ -465,10 +465,21 @@ int main (int argc, char **argv) > case 'h': > default: > usage: > - fprintf (stderr, "usage: %s [-n] [-D dev | -a | -A usbfs-dir]\n" > - "\t[-c iterations] [-t testnum]\n" > - "\t[-s packetsize] [-g sglen] [-v vary]\n", > - argv [0]); > + fprintf (stderr, > + "usage: %s [options]\n" > + "Options:\n" > + "\t-D dev only test specific device\n" > + "\t-A usbfs-dir\n" > + "\t-a test all recognized devices\n" > + "\t-l loop forever(for stress test)\n" > + "\t-t testnum only run specified case\n" > + "\t-n no test running, show devices to be tested\n" > + "Case arguments:\n" > + "\t-c iterations default 1000\n" > + "\t-s packetsize default 512\n" > + "\t-g sglen default 32\n" > + "\t-v vary default 512\n", > + argv[0]); > return 1; > } > if (optind != argc) -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------------------ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/