Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754164Ab2EWIzq (ORCPT ); Wed, 23 May 2012 04:55:46 -0400 Received: from ch1ehsobe003.messaging.microsoft.com ([216.32.181.183]:7428 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895Ab2EWIzm convert rfc822-to-8bit (ORCPT ); Wed, 23 May 2012 04:55:42 -0400 X-Forefront-Antispam-Report: CIP:198.70.193.64;KIP:(null);UIP:(null);IPV:NLI;H:avexcashub1.qlogic.com;RD:avexcashub2.qlogic.com;EFVD:NLI X-SpamScore: -12 X-BigFish: VPS-12(zz542M1432N98dKzz1202hzz8275eh8275bh8275dha1495iz2ei2a8h668h839h944he5bhf0ah) From: Vikas Chaudhary To: "gregkh@linuxfoundation.org" CC: linux-kernel , Mike Christie , James Bottomley , Lalit Chandivade , Ravi Anand Date: Wed, 23 May 2012 01:55:36 -0700 Subject: Re: Bug in sysfs bin attribute? Thread-Topic: Bug in sysfs bin attribute? Thread-Index: Ac04wdLMu7N3dS2zT3+N6IUot6srPg== Message-ID: In-Reply-To: <20120523061712.GA19773@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.2.2.120421 acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: qlogic.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1831 Lines: 39 -----Original Message----- From: "gregkh@linuxfoundation.org" To: Vikas Chaudhary Cc: linux-kernel , Mike Christie , James Bottomley , Lalit Chandivade , Ravi Anand Subject: Re: Bug in sysfs bin attribute? >On Tue, May 22, 2012 at 10:38:11PM -0700, Vikas Chaudhary wrote: >> >> We have added sysfs bin_attribute 'fw_dump' in qla4xxx driver. >> Here is patch for same: - >> http://marc.info/?l=linux-scsi&m=133733192809849&w=2 >> >> >> In this patch in function qla4_8xxx_sysfs_write_fw_dump() if we print >> string coming in 'char *buf' >> from sysfs attribute it contain value we echo on sysfs attribute >>'fw_dump' >> plus some garbage data. > >Why are you not using the built-in firmware interface the kernel >provides you? What does it lack that you need here? In this patch we are not trying to load firmware, Here we are trying to collect firmware dump in case of adapter firmware crash. The firmware dump is in driver buffer and we want to extract it at user space using the sysfs bin attribute. This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/