Message-ID: <1337769731.3666.8.camel@fourier.local.igalia.com>
Subject: Re: [PATCH 2/3] Staging: ipack: fix failure registering an ipack
 device
From: Samuel Iglesias =?ISO-8859-1?Q?Gons=E1lvez?= 
	<siglesias@igalia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Wed, 23 May 2012 12:42:11 +0200
In-Reply-To: <20120523104115.GL4637@mwanda>
References: <1337764395-23200-1-git-send-email-siglesias@igalia.com>
	 <1337764395-23200-2-git-send-email-siglesias@igalia.com>
	 <20120523104115.GL4637@mwanda>
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-HqFLMZdbBPSpfqaSuO9Z"
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1816
Lines: 55


--=-HqFLMZdbBPSpfqaSuO9Z
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2012-05-23 at 13:41 +0300, Dan Carpenter wrote:
> On Wed, May 23, 2012 at 11:13:14AM +0200, Samuel Iglesias Gonsalvez wrote=
:
> > Trying to install an ipack device it always failed in the match() funct=
ion. This
> > patch fixes all the bugs present there.
> >=20
>=20
> This looks like part of it is undoing stuff introduced in
> [patch 1/3]?  I was going to ask what the stuff was in 1/3 and then
> it got removed which makes me wonder why even more.  Could you write
> something about why in your changelog?  Or if it's not needed then
> remove it from the first patch.
>=20
> Really it would be easier to review if you broke it up into one
> patch per bug, with a description of what the bugs were instead of
> "patch fixes all the bugs present there".
>=20
> Some of these changes don't seem necessary.  It feels like you were
> debugging and then when you got match() to work you just committed
> all the changes instead of only the lines which are needed.
>=20

Yes, you are right. I will work again on these patches.

Thanks,

Sam


--=-HqFLMZdbBPSpfqaSuO9Z
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAk+8vwMACgkQWrfbyfmd9eJ5PQCgrTpvUOeCPkPmdjdPWKBORmeI
2V4AoICCQBsW7gdAS/lanaSt43Hvfa/b
=i5kp
-----END PGP SIGNATURE-----

--=-HqFLMZdbBPSpfqaSuO9Z--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/