Message-ID: <4FBCCC09.3020605@redhat.com>
Date: Wed, 23 May 2012 14:37:45 +0300
From: Avi Kivity <avi@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1
MIME-Version: 1.0
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
CC: Marcelo Tosatti <mtosatti@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH v5 0/9] KVM: fast page fault
References: <4FBCA4FB.8050501@linux.vnet.ibm.com>
In-Reply-To: <4FBCA4FB.8050501@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1275
Lines: 32

On 05/23/2012 11:51 AM, Xiao Guangrong wrote:
> Changlog:
> This are some changes from Marcelo's review:
> - drop SPTE_WRITE_PROTECT bit, now, only one bit is needed to do
>   lockless update.
> 
> - always atomicly update spte if it can be updated out of mmu-lock.
> 
> - flod the judgement of tlb flush into mmu_spte_update(), make the
>   code easilyer audited.
> 
> Performance result:
> - autoest migration test (smp2.Fedora.16.64.migrate.with_autotest.dbench.unix):
>                                                    before     after
> smp2.Fedora.16.64.migrate.unix                        93      91    +2.1%
> smp2.Fedora.16.64.migrate.with_autotest.dbench.unix   218     188   +13.7%
> 
> - the benchmark attached is used to measure the resuming time
>   after dirty-log
>                             before            after
> Run 10 times, Avg time:   512466818 ns.      269231261 ns   +47.5%

Still scary (esp. indirect sptes), but looks pretty good.


-- 
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/