Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933481Ab2EWN5G (ORCPT ); Wed, 23 May 2012 09:57:06 -0400 Received: from smtp3.mundo-r.com ([212.51.32.191]:50434 "EHLO smtp4.mundo-r.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759275Ab2EWNyx (ORCPT ); Wed, 23 May 2012 09:54:53 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAJHrvE9bdWOb/2dsb2JhbABDtDOBB4IWAQUnUhBRVwYBEogSukuQTwOVHI9wgmw X-IronPort-AV: E=Sophos;i="4.75,645,1330902000"; d="scan'208";a="518630130" From: Samuel Iglesias Gonsalvez To: Greg Kroah-Hartman , Dan Carpenter Cc: Samuel Iglesias Gonsalvez , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/8] Staging: ipack/bridges/tpci200: check if the remove function is available Date: Wed, 23 May 2012 15:54:44 +0200 Message-Id: <1337781287-28628-6-git-send-email-siglesias@igalia.com> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1337781287-28628-1-git-send-email-siglesias@igalia.com> References: <1337781287-28628-1-git-send-email-siglesias@igalia.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 987 Lines: 29 To avoid a dereference of a NULL pointer, the availability of the function is checked before its use. Signed-off-by: Samuel Iglesias Gonsalvez --- drivers/staging/ipack/bridges/tpci200.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/ipack/bridges/tpci200.c b/drivers/staging/ipack/bridges/tpci200.c index 0c2a50a..ee26d9a 100644 --- a/drivers/staging/ipack/bridges/tpci200.c +++ b/drivers/staging/ipack/bridges/tpci200.c @@ -764,6 +764,8 @@ out: static void tpci200_slot_remove(struct tpci200_slot *slot) { if ((slot->dev == NULL) || + (slot->dev->driver == NULL) || + (slot->dev->driver->ops == NULL) || (slot->dev->driver->ops->remove == NULL)) return; -- 1.7.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/