Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759903Ab2EWPCm (ORCPT ); Wed, 23 May 2012 11:02:42 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:51767 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752042Ab2EWPCk (ORCPT ); Wed, 23 May 2012 11:02:40 -0400 Date: Wed, 23 May 2012 11:02:39 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Lin Ming cc: Jens Axboe , , , Subject: Re: [RFC PATCH v3 1/4] block: add a flag to identify PM request In-Reply-To: <1337671292-15583-2-git-send-email-ming.m.lin@intel.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 724 Lines: 20 On Tue, 22 May 2012, Lin Ming wrote: > Add a flag REQ_PM to identify the request is PM related. > As an example, modify scsi code to use this flag. Don't forget to check up on the SCSI error handler. If I'm not mistaken, the libata drivers use it during suspend and resume. Also, the error handler will run if one of the REQ_PM commands encounters an error. Therefore it seems likely that every request submitted by the error handler needs to have REQ_PM set. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/