Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933766Ab2EWRhv (ORCPT ); Wed, 23 May 2012 13:37:51 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:46193 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933074Ab2EWRhu convert rfc822-to-8bit (ORCPT ); Wed, 23 May 2012 13:37:50 -0400 MIME-Version: 1.0 In-Reply-To: <20120523171125.GD18284@liondog.tnic> References: <1337684026-19740-1-git-send-email-bp@amd64.org> <1337789429.9783.16.camel@laptop> <4FBD0C47.70600@zytor.com> <20120523161932.GN14757@aftab.osrc.amd.com> <1337790571.9783.28.camel@laptop> <4FBD10D5.6080602@zytor.com> <20120523165303.GB18284@liondog.tnic> <20120523171125.GD18284@liondog.tnic> From: Linus Torvalds Date: Wed, 23 May 2012 10:37:28 -0700 X-Google-Sender-Auth: QNnNC8WPVYVOjtQT40WtYLhTuFE Message-ID: Subject: Re: [tip:x86/mce] x86/bitops: Move BIT_64() for a wider use To: Borislav Petkov , Linus Torvalds , "H. Peter Anvin" , Peter Zijlstra , Borislav Petkov , mingo@kernel.org, linux-kernel@vger.kernel.org, frank.arnold@amd.com, akpm@linux-foundation.org, tglx@linutronix.de, linux-tip-commits@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 639 Lines: 18 On Wed, May 23, 2012 at 10:11 AM, Borislav Petkov wrote: > > And, in addition, hpa's example won't work too: > > ? ? ? ?u64 msr = ~BIT(1); Yes, that's a good example of something that can be problematic, and is fundamentally different on 32-bit and 64-bit. So maybe BIT() unconditionally being long, and BIT_64() being u64 simply is the right model. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/