Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933910Ab2EWTET (ORCPT ); Wed, 23 May 2012 15:04:19 -0400 Received: from relay1.sgi.com ([192.48.179.29]:42294 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933848Ab2EWTEQ (ORCPT ); Wed, 23 May 2012 15:04:16 -0400 Date: Wed, 23 May 2012 14:04:14 -0500 From: Dimitri Sivanich To: Thomas Gleixner Cc: Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Suresh Siddha , Yinghai Lu , Naga Chumbalkar , Jacob Pan , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: check for valid irq_cfg pointer in smp_irq_move_cleanup_interrupt Message-ID: <20120523190414.GA5263@sgi.com> References: <20120521164959.GE16454@sgi.com> <20120521211917.GA25567@sgi.com> <20120523181636.GA2032@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120523181636.GA2032@sgi.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 631 Lines: 12 On Wed, May 23, 2012 at 01:16:36PM -0500, Dimitri Sivanich wrote: > In create_irq_nr() there is a window where we have set vector_irq in > __assign_irq_vector(), but not yet called irq_set_chip_data() to set the > irq_cfg pointer. BTW - is there a reason why we're calling irq_set_chip_data() in create_irq_nr() rather than in __assign_irq_vector() for the case where irq_cfg is NULL? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/