Date: Wed, 23 May 2012 20:17:50 +0100
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: linux-kernel@vger.kernel.org, Russ.Dill@ti.com, mporter@ti.com
Subject: Re: [PATCH] [ARM] Unconditional call to smp_cross_call on UP
	crashes
Message-ID: <20120523191750.GA7608@n2100.arm.linux.org.uk>
References: <1337879399-9998-1-git-send-email-panto@antoniou-consulting.com> <20120523185248.GA6908@n2100.arm.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120523185248.GA6908@n2100.arm.linux.org.uk>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1129
Lines: 24

On Wed, May 23, 2012 at 07:52:48PM +0100, Russell King - ARM Linux wrote:
> On Thu, May 24, 2012 at 05:09:59PM +0000, Pantelis Antoniou wrote:
> > omap2plus_defconfig builds with SMP & SMP_ON_UP set.
> > On beagle (which is UP) is_smp() returns false and we don't call
> > smp_init_cpus which in turn does not initialize smp_cross_call which
> > remains NULL.
> > 
> > When issuing a reboot we OOPS with a NULL dereference on stop smp_call.
> > 
> > Fixed by checking is_smp in smp_send_stop()
> 
> 1. No sign-off, so this patch _can't_ be committed.
> 
> 2. Poor description.  You say it oopses, but you don't include the oops.
> So, when I read this I've no idea exactly why this is failing.  And it
> _shouldn't_ fail, so I want to know what you are seeing.

And 3. not sent to linux-arm-kernel (please copy with patches so everyone
in the ARM community is aware of them, thanks.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/