Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760790Ab2EWUwy (ORCPT ); Wed, 23 May 2012 16:52:54 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:21098 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758666Ab2EWUwx (ORCPT ); Wed, 23 May 2012 16:52:53 -0400 Date: Wed, 23 May 2012 16:46:12 -0400 From: Konrad Rzeszutek Wilk To: Minchan Kim Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Seth Jennings , Dan Magenheimer , Nitin Gupta Subject: Re: [PATCH 1/2 v2] zsmalloc: zsmalloc: use unsigned long instead of void * Message-ID: <20120523204611.GA1991@phenom.dumpdata.com> References: <1337737402-16543-1-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1337737402-16543-1-git-send-email-minchan@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 904 Lines: 23 On Wed, May 23, 2012 at 10:43:21AM +0900, Minchan Kim wrote: > We should use unsigned long as handle instead of void * to avoid any > confusion. Without this, users may just treat zs_malloc return value as > a pointer and try to deference it. > > This patch passed compile test(zram, zcache and ramster) and zram is > tested on qemu. > > changelog > * from v1 > - change zcache's zv_create return value > - baesd on next-20120522 > > Cc: Seth Jennings > Cc: Dan Magenheimer > Cc: Konrad Rzeszutek Wilk Acked-by: Konrad Rzeszutek Wilk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/