Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753382Ab2EXAgn (ORCPT ); Wed, 23 May 2012 20:36:43 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:53162 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751745Ab2EXAgk (ORCPT ); Wed, 23 May 2012 20:36:40 -0400 Date: Wed, 23 May 2012 17:36:38 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Mark Brown cc: Linus Torvalds , Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch -linus] regmap: REMAP_IRQ should select IRQ_DOMAIN itself In-Reply-To: <20120523173342.GB4064@opensource.wolfsonmicro.com> Message-ID: References: <20120522183037.75ec03c9d8881ec188e7f787@canb.auug.org.au> <4FBBAF1B.1070702@xenotime.net> <20120523093208.GB4085@opensource.wolfsonmicro.com> <20120523173342.GB4064@opensource.wolfsonmicro.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1188 Lines: 30 On Wed, 23 May 2012, Mark Brown wrote: > > Multi-level pure selects *should* work correctly. So you can select > > stuff that then in turn selects other stuff - and that should all be > > fine. > > They're supposed to, and mostly do, but there's been some fragility > there. That said there's not been anything recently, perhaps I just got > hit with fallout from some development that was going on. > > > It's *dependencies* that do not work. > > Right, and nor are they supposed to since it's not clear what they > should do. That's a completely different thing. > So my patch to select IRQ_DOMAIN for REGMAP_IRQ is correct since REGMAP_IRQ now requires IRC_DOMAIN since the commit listed in the changelog. What's fragile is going around and adding "select IRQ_DOMAIN" to everything that does "select REGMAP_IRQ". So I removed that and just made IRQ_DOMAIN select REGMAP_IRQ itself. So can this be merged or what's the issue? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/