Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757521Ab2EXDUG (ORCPT ); Wed, 23 May 2012 23:20:06 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:42045 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756011Ab2EXDUE (ORCPT ); Wed, 23 May 2012 23:20:04 -0400 Date: Thu, 24 May 2012 11:20:29 +0800 From: Shawn Guo To: Richard Zhao Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vinod.koul@intel.com, dan.j.williams@intel.com, linuxzsc@gmail.com, shawn.guo@gmail.com, kernel@pengutronix.de Subject: Re: [PATCH 1/1] dma: imx-sdma: buf_tail should be initialize in prepare function Message-ID: <20120524032026.GB17621@S2101-09.ap.freescale.net> References: <1337603494-27464-1-git-send-email-richard.zhao@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1337603494-27464-1-git-send-email-richard.zhao@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 24 On Mon, May 21, 2012 at 08:31:34PM +0800, Richard Zhao wrote: > This fix audio underrun issue. When SNDRV_PCM_TRIGGER_STOP > and SNDRV_PCM_TRIGGER_START, it calls prepare again. buf_tail > should be reset to zero. > So move buf_tail initialization into prepare function. > I tried the patch on imx51, and it does not fix the issue for me. Regards, Shawn root@linaro-developer:~# aplay audio8k16S.wav Playing WAVE 'audio8k16S.wav' : Signed 16 bit Little Endian, Rate 8000 Hz, Stere o ^Z [1]+ Stopped aplay audio8k16S.wav root@linaro-developer:~# fg aplay audio8k16S.wav underrun!!! (at least 2034.382 ms long) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/