Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751471Ab2EXEHq (ORCPT ); Thu, 24 May 2012 00:07:46 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:44498 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344Ab2EXEHp convert rfc822-to-8bit (ORCPT ); Thu, 24 May 2012 00:07:45 -0400 MIME-Version: 1.0 In-Reply-To: <20120524004851.GB7843@S2100-06.ap.freescale.net> References: <201205221053.21792.marc@cpdesign.com.au> <20120523084945.GA4085@opensource.wolfsonmicro.com> <20120523164203.GA7843@S2100-06.ap.freescale.net> <20120524004851.GB7843@S2100-06.ap.freescale.net> Date: Thu, 24 May 2012 01:07:43 -0300 Message-ID: Subject: Re: mc13xxx-core: kernel hangs after 'regmap_read' From: Fabio Estevam To: Shawn Guo Cc: Mark Brown , marc@cpdesign.com.au, Samuel Ortiz , Sascha Hauer , =?UTF-8?Q?Philippe_R=C3=A9tornaz?= , linux-kernel Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 37 Shawn, On Wed, May 23, 2012 at 9:48 PM, Shawn Guo wrote: > I'm booting my imx51 babbage with MC13892 with no problem now.  And > reading the registers give me the same values as I do with u-boot. Ok, just to confirm: is the patch below that you are using? diff --git a/drivers/mfd/mc13xxx-spi.c b/drivers/mfd/mc13xxx-spi.c index 3fcdab3..5d1969f 100644 --- a/drivers/mfd/mc13xxx-spi.c +++ b/drivers/mfd/mc13xxx-spi.c @@ -49,6 +49,7 @@ static struct regmap_config mc13xxx_regmap_spi_config = { .reg_bits = 7, .pad_bits = 1, .val_bits = 24, + .write_flag_mask = 0x80, .max_register = MC13XXX_NUMREGS, @@ -73,7 +74,6 @@ static int mc13xxx_spi_probe(struct spi_device *spi) dev_set_drvdata(&spi->dev, mc13xxx); spi->mode = SPI_MODE_0 | SPI_CS_HIGH; - spi->bits_per_word = 32; mc13xxx->dev = &spi->dev; mutex_init(&mc13xxx->lock); I am trying to understand why mx31pdk still fails. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/