Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753848Ab2EXIOR (ORCPT ); Thu, 24 May 2012 04:14:17 -0400 Received: from mga11.intel.com ([192.55.52.93]:52614 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752759Ab2EXIOL (ORCPT ); Thu, 24 May 2012 04:14:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="asc'?scan'208";a="170759533" Message-ID: <1337847472.15137.81.camel@sauron.fi.intel.com> Subject: Re: [PATCH] [RFC] UBI: Implement Fastmap support From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Richard Weinberger Cc: Shmulik Ladkani , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Heinz.Egger@linutronix.de, tim.bird@am.sony.com, tglx@linutronix.de Date: Thu, 24 May 2012 11:17:52 +0300 In-Reply-To: <4FBBC4EE.4040802@nod.at> References: <1337608916-49771-1-git-send-email-richard@nod.at> <1337608916-49771-2-git-send-email-richard@nod.at> <20120522180119.2c2a10a8@pixies.home.jungo.com> <4FBBC4EE.4040802@nod.at> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-p2HPywNjchkueQDc4we+" X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2260 Lines: 61 --=-p2HPywNjchkueQDc4we+ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2012-05-22 at 18:55 +0200, Richard Weinberger wrote: > >> + e =3D find_early_wl_entry(&ubi->free, max_pnum); > > > > This picks the eb with the lowest pnum within 'ubi->free'. > > > > When called with INT_MAX (for the FM_DATA), why do you need to pick > a > > free eb with the minimal pnum? The FM_DATA EBs may reside everywhere > (as > > the FM_SB holds their location). > > So why not pick the eb with a medium EC value (as done for standard > > get_peb calls)? That might be better wear-leveling wise. >=20 > Fair point. > I'll fix that. > Artem, any comments on that? The 'find_early_wl_entry()' function is used (currently) only at early stages. At these stages the we do not have the PEBs sorted by EC. We have just a list. This function should not be use after the WL subsystem is initialized. >=20 --=20 Best Regards, Artem Bityutskiy --=-p2HPywNjchkueQDc4we+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAABAgAGBQJPve6wAAoJECmIfjd9wqK08bsQALMJrcYQVWfSKXDcT2IPDIF/ 1qZKMG9Pi7bgesUEXQIC/N9uvUDUlYCmTpZg0CzqWJKh36hKF6v/9qkMkVbk/MSa Q0vR+HTe51ilNzAXBr6XNMo5FIL5Kx85Z1f1xbvjZlvl63yDkwVSGycY1CVM69sE lV2VZGNVjovi4GcIhzx0H3PNtJgJzndn4QseWbKn/5Zdv7enaojDdiwIS6PSoBYH FHufYl18bBuxZZSsRtXH9W7PV57lptV6PdPq4eu/mVeeQgMLu8mJuMdkfiOBUmns V3cyN6HDnT8uQGUXRcgjxEoYwdfPQANOEw0jrHo6+MJnaDBgVvU8GVT2ynoOGHnq P7TLkNHGF8Sh3lbyiRB+djtUkHbKqpe+tMCArCOHSKUTNgQgFpH5bYSMcZgmnWPA rsCH4EzN+a3CnyMbv2hHNFd+4xbOHfaEOgE9aKgAP9Qp9pYjo6oNNmwIZnKQ0W1+ 4WxoAa98CypRox+6X3OrijjCe/5M7BVebLE4RGrC68jjDnDwGxbgChFIx4vBl/Jr qh4KWKG8H/zrpof0cQXnrk0ONz8m09rjnwBtLqhTlSOvdld/G1mA3MoUX9M/4U5t WpEgdsxPydU0okQE2f4g46EzZkgojU8GPwG953Z31n6dtriI7Js6cD0HxZrndSj7 v7hCDMsyhR5QwHVSUSmz =qvHp -----END PGP SIGNATURE----- --=-p2HPywNjchkueQDc4we+-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/