Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755354Ab2EXNXm (ORCPT ); Thu, 24 May 2012 09:23:42 -0400 Received: from merlin.infradead.org ([205.233.59.134]:59872 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753352Ab2EXNXl (ORCPT ); Thu, 24 May 2012 09:23:41 -0400 Subject: Re: [PATCH v7 8/8] x86/tlb: just do tlb flush on one of siblings of SMT From: Peter Zijlstra To: Andrew Lutomirski Cc: Jan Beulich , Alex Shi , borislav.petkov@amd.com, arnd@arndb.de, akinobu.mita@gmail.com, eric.dumazet@gmail.com, fweisbec@gmail.com, rostedt@goodmis.org, hughd@google.com, jeremy@goop.org, len.brown@intel.com, tony.luck@intel.com, yongjie.ren@intel.com, kamezawa.hiroyu@jp.fujitsu.com, seto.hidetoshi@jp.fujitsu.com, penberg@kernel.org, yinghai@kernel.org, tglx@linutronix.de, akpm@linux-foundation.org, ak@linux.intel.com, avi@redhat.com, dhowells@redhat.com, mingo@redhat.com, riel@redhat.com, cpw@sgi.com, steiner@sgi.com, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, hpa@zytor.com, Arjan Van De Ven In-Reply-To: References: <1337782555-8088-1-git-send-email-alex.shi@intel.com> <1337782555-8088-9-git-send-email-alex.shi@intel.com> <4FBD18D20200007800085951@nat28.tlf.novell.com> <1337792984.9783.37.camel@laptop> <1337793338.9783.38.camel@laptop> <1337845230.9783.51.camel@laptop> Content-Type: text/plain; charset="UTF-8" Date: Thu, 24 May 2012 15:23:31 +0200 Message-ID: <1337865811.9783.152.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 768 Lines: 19 On Thu, 2012-05-24 at 06:19 -0700, Andrew Lutomirski wrote: > > A decent heuristic might be to prefer idle SMT siblings for TLB > invalidation. I don't know what effect that would have on power > consumption (it would be rather bad if idling one SMT thread while the > other one is busy saves much power). Right, I've never really understood how C-states and SMT go together. Arjan recently implied waking a thread sibling from C-state was 'expensive' which on first thought seems daft, the core is running already. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/