Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933179Ab2EXOi0 (ORCPT ); Thu, 24 May 2012 10:38:26 -0400 Received: from cpsmtpb-ews06.kpnxchange.com ([213.75.39.9]:4754 "EHLO cpsmtpb-ews06.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932152Ab2EXOiZ (ORCPT ); Thu, 24 May 2012 10:38:25 -0400 Message-ID: <1337870303.22505.20.camel@x61.thuisdomein> Subject: [PATCH] Drop superfluous setting of i2c_board_info.type From: Paul Bolle To: Sascha Hauer , Russell King , Paul Mundt , Magnus Damm Cc: linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 24 May 2012 16:38:23 +0200 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-OriginalArrivalTime: 24 May 2012 14:38:23.0468 (UTC) FILETIME=[DF2E82C0:01CD39BA] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2290 Lines: 60 Three instances of struct i2c_board_info have their "type" member set to "tsc2007" twice. First through the I2C_BOARD_INFO macro and then directly. Drop the superfluous second setting. Signed-off-by: Paul Bolle --- 0) Entirely untested. I'm unsure what toolchain(s) is (are) needed to compile this and I am certain that I don't have the hardware. 1) This is apparently legal. Doesn't gcc issue a warning for this? arch/arm/mach-imx/mach-cpuimx35.c | 1 - arch/arm/mach-imx/mach-cpuimx51sd.c | 1 - arch/arm/mach-shmobile/board-ap4evb.c | 1 - 3 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-imx/mach-cpuimx35.c b/arch/arm/mach-imx/mach-cpuimx35.c index 8ecc872..b1a4796 100644 --- a/arch/arm/mach-imx/mach-cpuimx35.c +++ b/arch/arm/mach-imx/mach-cpuimx35.c @@ -70,7 +70,6 @@ static struct i2c_board_info eukrea_cpuimx35_i2c_devices[] = { I2C_BOARD_INFO("pcf8563", 0x51), }, { I2C_BOARD_INFO("tsc2007", 0x48), - .type = "tsc2007", .platform_data = &tsc2007_info, .irq = IMX_GPIO_TO_IRQ(TSC2007_IRQGPIO), }, diff --git a/arch/arm/mach-imx/mach-cpuimx51sd.c b/arch/arm/mach-imx/mach-cpuimx51sd.c index 9fbe923..89eb93c 100644 --- a/arch/arm/mach-imx/mach-cpuimx51sd.c +++ b/arch/arm/mach-imx/mach-cpuimx51sd.c @@ -124,7 +124,6 @@ static struct i2c_board_info eukrea_cpuimx51sd_i2c_devices[] = { I2C_BOARD_INFO("pcf8563", 0x51), }, { I2C_BOARD_INFO("tsc2007", 0x49), - .type = "tsc2007", .platform_data = &tsc2007_info, .irq = IMX_GPIO_TO_IRQ(TSC2007_IRQGPIO), }, diff --git a/arch/arm/mach-shmobile/board-ap4evb.c b/arch/arm/mach-shmobile/board-ap4evb.c index b56dde2..801de4b 100644 --- a/arch/arm/mach-shmobile/board-ap4evb.c +++ b/arch/arm/mach-shmobile/board-ap4evb.c @@ -1168,7 +1168,6 @@ static struct tsc2007_platform_data tsc2007_info = { static struct i2c_board_info tsc_device = { I2C_BOARD_INFO("tsc2007", 0x48), - .type = "tsc2007", .platform_data = &tsc2007_info, /*.irq is selected on ap4evb_init */ }; -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/