Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758171Ab2EXReM (ORCPT ); Thu, 24 May 2012 13:34:12 -0400 Received: from mail.skyhub.de ([78.46.96.112]:43270 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752613Ab2EXReK (ORCPT ); Thu, 24 May 2012 13:34:10 -0400 Date: Thu, 24 May 2012 19:34:05 +0200 From: Borislav Petkov To: Thomas Gleixner Cc: Borislav Petkov , Chen Gong , "Luck, Tony" , "x86@kernel.org" , LKML , Peter Zijlstra Subject: Re: [PATCH] x86: auto poll/interrupt mode switch for CMC to stop CMC storm Message-ID: <20120524173405.GA6882@liondog.tnic> Mail-Followup-To: Borislav Petkov , Thomas Gleixner , Borislav Petkov , Chen Gong , "Luck, Tony" , "x86@kernel.org" , LKML , Peter Zijlstra References: <1337740341-26711-1-git-send-email-gong.chen@linux.intel.com> <3908561D78D1C84285E8C5FCA982C28F192F2DD6@ORSMSX104.amr.corp.intel.com> <3908561D78D1C84285E8C5FCA982C28F192F30C0@ORSMSX104.amr.corp.intel.com> <4FBD9BAA.7070902@linux.intel.com> <20120524060016.GB25344@aftab.osrc.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1063 Lines: 25 On Thu, May 24, 2012 at 12:01:13PM +0200, Thomas Gleixner wrote: > Aside of that machine_check_poll is called from other places as > well. So looking at mce_timer_start() which is surprisingly the timer > callback: > > The poll timer rate is self adjusting to intervals down to HZ/100. So > when you get into a state where the timer rate becomes lower than HZ/5 > we'll trigger that CMCI storm in software and queue work even on > machines which do not support CMCI or have it disabled. Brilliant, > isn't it? > > So that rate check belongs into intel_treshold_interrupt() and wants a > intel specific callback in mce_start_timer() to undo it. Ok, I see it now, it took me awhile with my slow brain. And the code is not a walk in the park anyway, thanks Thomas for pointing this out. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/