Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759207Ab2EXUnK (ORCPT ); Thu, 24 May 2012 16:43:10 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:42952 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756374Ab2EXUnG (ORCPT ); Thu, 24 May 2012 16:43:06 -0400 MIME-Version: 1.0 In-Reply-To: <4FBE5518.5090705@redhat.com> References: <4FBE5518.5090705@redhat.com> From: Linus Torvalds Date: Thu, 24 May 2012 13:42:45 -0700 X-Google-Sender-Auth: meB_ttkc5w3nNSVyep4Mxp228Dc Message-ID: Subject: Re: [GIT PULL for v3.5-rc1] media updates for v3.5 To: Mauro Carvalho Chehab Cc: Andrew Morton , Linux Media Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1675 Lines: 48 Btw, I only noticed now, because I normally don't build DVB on my main machine with "oldconfig" - why the hell does DVB add tuners with "default m"? Why would *anybody* with an old config ever want to get those new drivers as modules? Get rid of all the stupid default m if DVB_FE_CUSTOMISE because there's no reason for them. If somebody wants that module, they can damn well press the 'm' button. There's absolutely no reason for it to default to on. This is true of *all* drivers. No driver (and certainly DVB is not at all an exception) is so important that it should be "default m" (or y). There are a few valid reasons to use "default m/y", but I don't see that that is the case here: - if you have an *existing* driver that got split up, and "make oldconfig" with that old driver enabled would result in it no longer supporting the same capability, then a default OLD_DRIVER_WAS_ENABLED is appropriate - it makes "oldconfig" work the way people expect it to work. But this is only when that piece of hardware used to be supported already, it's irrelevant for new hardware. - if it's *such* a basic piece of hardware that you simply don't want to bother the user with an insane default. Like supporting an ATKBD driver on a PC etc. This simply isn't true for media devices. So stop doing the silly "enable this driver by default for old configurations". It's *wrong*. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/