Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934128Ab2EXV4z (ORCPT ); Thu, 24 May 2012 17:56:55 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:35267 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932105Ab2EXV4x (ORCPT ); Thu, 24 May 2012 17:56:53 -0400 MIME-Version: 1.0 In-Reply-To: <20120524213813.GA17452@core.coreip.homeip.net> References: <20120524083216.GD10562@core.coreip.homeip.net> <20120524180154.GA15036@core.coreip.homeip.net> <20120524195851.GA15306@core.coreip.homeip.net> <20120524203647.GA16024@core.coreip.homeip.net> <20120524205952.GA16621@core.coreip.homeip.net> <20120524213813.GA17452@core.coreip.homeip.net> From: Linus Torvalds Date: Thu, 24 May 2012 14:56:31 -0700 X-Google-Sender-Auth: cx2-YLrKnmTQT0cfRff9eeA_eK8 Message-ID: Subject: Re: [git pull] Input updates for 3.5-rc0 To: Dmitry Torokhov Cc: Greg Kroah-Hartman , Andrew Morton , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1452 Lines: 33 On Thu, May 24, 2012 at 2:38 PM, Dmitry Torokhov wrote: > > Maybe dev_XXX() should report full sysfs path do the dveice? Still does > not help with the fact that "driver" shown for class devices is not so > interesting as it will always be the class name. Well, the dev_printk logic could certainly have simple rules to avoid duplicate information. And perhaps pick the most relevant parts using some heuristics. Right now it just prints out "%s %s" for dev_driver_string(dev) and dev_name(dev) respectively. That really isn't all that wonderfully beautiful, and results in things like hid-generic 0003:046D:C526.0006: xyz for my Logitech USB Receiver. That's kind of ugly, and really doesn't clarify anything at all, I think. The "driver + dev_name()" works fine for things like PCI devices, but even then it's partly because the PCI layer has made sure to make the device name pretty - and the device name contains the (redundant) data of which bus number it is on, even though that's strictly a matter of the parent thing (but the device name has been prettified and contains redundant information exactly so that it would print out nicely). Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/