Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933725Ab2EXV5E (ORCPT ); Thu, 24 May 2012 17:57:04 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:32950 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934133Ab2EXV5A (ORCPT ); Thu, 24 May 2012 17:57:00 -0400 Date: Thu, 24 May 2012 14:56:54 -0700 From: Dmitry Torokhov To: Linus Torvalds Cc: Greg Kroah-Hartman , Andrew Morton , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [git pull] Input updates for 3.5-rc0 Message-ID: <20120524215654.GB17452@core.coreip.homeip.net> References: <20120524180154.GA15036@core.coreip.homeip.net> <20120524195851.GA15306@core.coreip.homeip.net> <20120524203647.GA16024@core.coreip.homeip.net> <20120524205952.GA16621@core.coreip.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1863 Lines: 47 On Thu, May 24, 2012 at 02:44:31PM -0700, Linus Torvalds wrote: > On Thu, May 24, 2012 at 2:07 PM, Linus Torvalds > wrote: > > On Thu, May 24, 2012 at 1:59 PM, Dmitry Torokhov > > wrote: > >> > >> I was concerned about the _next_ device (the one that will be created > >> the moment I plug in the tablet back into the same port) having exact > >> same name as the one that is half dead and clashing in sysfs and > >> elsewhere. We used to have issues with this. > > > > Ok, that's certainly a valid concern. > > > > It's still - I think - really sad/wrong that the device name is then > > so useless than the drivers end up basically not using it. > > Ok, so I wonder if we could solve the issue at least partly by > separating the "print name for kernel messages" from the "name used > for /sysfs etc". > > Because you're right: the sysfs uniqueness rules does make it very > hard to do a good job on descriptive names. > > Also, in sysfs, you by definition see the parent (hey, it's part of > the path), so in sysfs, duplicating parent data would be useless and > just ugly. > > But for dev_dbg(), those sysfs rules actually act against us: the name > of a device is often tied to the parent bus location. > > So I wonder if we could teach dev_printk() to use something more > interesting than "dev_name()" when appropriate? Greg? Maybe we could traverse up the tree till we find first non-class device (i.e. device with real driver bound to it)? Then we'd have: wacom 2-1.2:1.0/inputX/eventY: some error happened type of messages... -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/