Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753021Ab2EYHlU (ORCPT ); Fri, 25 May 2012 03:41:20 -0400 Received: from mail.skyhub.de ([78.46.96.112]:54340 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164Ab2EYHlS (ORCPT ); Fri, 25 May 2012 03:41:18 -0400 Date: Fri, 25 May 2012 09:41:14 +0200 From: Borislav Petkov To: ShuoX Liu Cc: "linux-kernel@vger.kernel.org" , Yanmin Zhang , Andrew Morton , andi@firstfloor.org, Tony Luck , Ingo Molnar Subject: Re: [PATCH 2/2] x86 mce: use new printk recursion disabling interface Message-ID: <20120525074114.GA5417@liondog.tnic> Mail-Followup-To: Borislav Petkov , ShuoX Liu , "linux-kernel@vger.kernel.org" , Yanmin Zhang , Andrew Morton , andi@firstfloor.org, Tony Luck , Ingo Molnar References: <4FBC444A.6060500@intel.com> <20120523100138.GA13506@x1.osrc.amd.com> <4FBDCE4A.7050900@intel.com> <20120524061145.GA18284@liondog.tnic> <20120524155611.b7aeff4d.akpm@linux-foundation.org> <1337905811.14538.206.camel@ymzhang.sh.intel.com> <4FBF3295.7090608@intel.com> <4FBF32E8.90101@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4FBF32E8.90101@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 43 On Fri, May 25, 2012 at 03:21:12PM +0800, ShuoX Liu wrote: > From: ShuoX Liu > > Disable printk recursion to make sure MCE logs printed out. > > Signed-off-by: Yanmin Zhang > Signed-off-by: ShuoX Liu > --- > arch/x86/kernel/cpu/mcheck/mce.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c > index 2afcbd2..365c35d 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce.c > +++ b/arch/x86/kernel/cpu/mcheck/mce.c > @@ -1015,6 +1015,7 @@ void do_machine_check(struct pt_regs *regs, long error_code) > DECLARE_BITMAP(toclear, MAX_NR_BANKS); > char *msg = "Unknown"; > > + printk_recursion_check_disable(); > atomic_inc(&mce_entry); > > this_cpu_inc(mce_exception_count); > @@ -1144,6 +1145,7 @@ void do_machine_check(struct pt_regs *regs, long error_code) > mce_wrmsrl(MSR_IA32_MCG_STATUS, 0); > out: > atomic_dec(&mce_entry); > + printk_recursion_check_enable(); Looks like those should be at the beginning and the end of print_mce() - do_machine_check() could exit without printing an MCE and disabling the recursion check then is superfluous, methinks. Thanks. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/