MIME-Version: 1.0
In-Reply-To: <1337932267.2932.7.camel@dabdike.int.hansenpartnership.com>
References: <20120525074813.21933.91876.stgit@dwillia2-linux.jf.intel.com>
	<20120525075027.21933.75815.stgit@dwillia2-linux.jf.intel.com>
	<1337932267.2932.7.camel@dabdike.int.hansenpartnership.com>
Date: Fri, 25 May 2012 01:18:21 -0700
Message-ID: <CABE8wwtfW0FusNuOEmwMxZLVMTVSj0R9HCA5xLWidrgj_7Ax+A@mail.gmail.com>
Subject: Re: [PATCH 1/4] async: introduce 'async_domain' type
From: Dan Williams <dan.j.williams@intel.com>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: mroos@linux.ee, linux-scsi@vger.kernel.org,
        Mark Brown <broonie@opensource.wolfsonmicro.com>,
        linux-kernel@vger.kernel.org, Arjan van de Ven <arjan@linux.intel.com>,
        Liam Girdwood <lrg@ti.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1669
Lines: 40

On Fri, May 25, 2012 at 12:51 AM, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
> On Fri, 2012-05-25 at 00:50 -0700, Dan Williams wrote:
>> This is in preparation for teaching async_synchronize_full() to sync all
>> pending async work, and not just on the async_running domain. ?This
>> conversion is functionally equivalent, just embedding the existing list
>> in a new async_domain type.
>
> This looks good, but I want Arjan and others who invented the async code
> to speed up boot to comment on all of this. ?What was the intention of
> async_synchronize_full() and if it wasn't to synchronise all domains,
> should we fix the documentation and add a new primitive to do that,
> since boot clearly assumes the all domains behaviour.
>
> In the mean time, this is probably all a bit much for a merge window, so
> I'll revert
>
> commit a7a20d103994fd760766e6c9d494daa569cbfe06
> Author: Dan Williams <dan.j.williams@intel.com>
> Date: ? Thu Mar 22 17:05:11 2012 -0700
>
> ? ?[SCSI] sd: limit the scope of the async probe domain
>
> And we'll put whatever is chosen in early for the next merge window.
>

Makes sense... but could also go ahead with the smaller fix I posted
for 3.5.  Meelis confirms it is working.

Otherwise this leaves the pending libsas suspend/resume support in
limbo, since it will certainly deadlock in the case where any device
fails, or is slow to come back from resume.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/