Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932626Ab2EYMMt (ORCPT ); Fri, 25 May 2012 08:12:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31983 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757194Ab2EYMMs (ORCPT ); Fri, 25 May 2012 08:12:48 -0400 Message-ID: <4FBF773B.10408@redhat.com> Date: Fri, 25 May 2012 09:12:43 -0300 From: Mauro Carvalho Chehab User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Linus Torvalds CC: Andrew Morton , Linux Media Mailing List , Linux Kernel Mailing List Subject: Re: [GIT PULL for v3.5-rc1] media updates for v3.5 References: <4FBE5518.5090705@redhat.com> <4FBEB72D.4040905@redhat.com> In-Reply-To: X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2593 Lines: 72 Em 24-05-2012 19:40, Linus Torvalds escreveu: > On Thu, May 24, 2012 at 3:33 PM, Mauro Carvalho Chehab > wrote: >> >> The Kconfig default for DVB_FE_CUSTOMISE is 'n'. So, if no DVB bridge is selected, >> nothing will be compiled. > > Sadly, it looks like the default for distro kernels is 'y'. I'll change the default on Fedora (f16/f17/rawhide). > Which means that if you start with a distro kernel config, and then > try to cut it down to match your system, you end up screwed in the > future - all the new hardware will default to on. > > At least that's how I noticed it. Very annoying. A simple way to solve it seems to make those options dependent on CONFIG_EXPERT. Not sure if all usual distributions disable it, but I guess most won't have EXPERT enabled. The enclosed patch does that. If nobody complains, I'll submit it together with the next git pull request. Regards, Mauro - [RFC PATCH] Make tuner/frontend options dependent on EXPERT The media CUSTOMISE options are there to allow embedded systems and advanced users to disable tuner/frontends that are supported by a bridge driver to be disabled, in order to save some disk space and memory, when compiled builtin. However, distros are mistakenly enabling it, causing problems when a make oldconfig is used. Make those options dependent on EXPERT, in order to avoid such annoyance behavior. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/common/tuners/Kconfig b/drivers/media/common/tuners/Kconfig index bbf4945..702a3bf 100644 --- a/drivers/media/common/tuners/Kconfig +++ b/drivers/media/common/tuners/Kconfig @@ -35,6 +35,7 @@ config MEDIA_TUNER config MEDIA_TUNER_CUSTOMISE bool "Customize analog and hybrid tuner modules to build" depends on MEDIA_TUNER + depends on EXPERT default y if EXPERT help This allows the user to deselect tuner drivers unnecessary diff --git a/drivers/media/dvb/frontends/Kconfig b/drivers/media/dvb/frontends/Kconfig index b98ebb2..6d3c2f7 100644 --- a/drivers/media/dvb/frontends/Kconfig +++ b/drivers/media/dvb/frontends/Kconfig @@ -1,6 +1,7 @@ config DVB_FE_CUSTOMISE bool "Customise the frontend modules to build" depends on DVB_CORE + depends on EXPERT default y if EXPERT help This allows the user to select/deselect frontend drivers for their -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/