Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754772Ab2EYNwP (ORCPT ); Fri, 25 May 2012 09:52:15 -0400 Received: from casper.infradead.org ([85.118.1.10]:33915 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430Ab2EYNwO (ORCPT ); Fri, 25 May 2012 09:52:14 -0400 Subject: Re: [PATCH] tty: tty_mutex: fix lockdep warning in tty_lock_pair(v1) From: Peter Zijlstra To: Alan Cox Cc: Ming Lei , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Arnd Bergmann In-Reply-To: <20120525144713.6946df1e@bob.linux.org.uk> References: <1337651931-5301-1-git-send-email-ming.lei@canonical.com> <1337952533.9783.195.camel@laptop> <20120525144713.6946df1e@bob.linux.org.uk> Content-Type: text/plain; charset="UTF-8" Date: Fri, 25 May 2012 15:52:02 +0200 Message-ID: <1337953922.9783.205.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 792 Lines: 18 On Fri, 2012-05-25 at 14:47 +0100, Alan Cox wrote: > > Having looked at the source I still don't see how it could possibly > > work,.. So the problem with tty_release() -> tty_ldisc_release() is > > that tty_ldisc_release() does an unlock/lock of tty. > > Yes it should do the pair, see the patch I posted restructing it, and > the second one restructing it right. http://marc.info/?l=linux-kernel&m=133794355529930 That one? To what tree does one apply that? Because the tty_lock_pair() in Linus is still missing a lockdep annotation afaict. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/