Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <87k400i9y1.fsf@tucsk.pomaz.szeredi.hu>
References: <87k400i9y1.fsf@tucsk.pomaz.szeredi.hu> <1335357857-16416-1-git-send-email-miklos@szeredi.hu> <6422.1337872046@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: dhowells@redhat.com, viro@ZenIV.linux.org.uk,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        hch@infradead.org, torvalds@linux-foundation.org
Subject: Re: [PATCH 00/16] vfs: atomic open v4 (part 1)
Date: Fri, 25 May 2012 16:18:39 +0100
Message-ID: <13673.1337959119@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 910
Lines: 27

Miklos Szeredi <miklos@szeredi.hu> wrote:

> > For instance, in lookup_open(), you call security_path_mknod() prior to
> > calling vfs_create(), but you don't call it prior to calling atomic_open()
> > or in, say, nfs_atomic_open().
> 
> We call security_path_mknod() before ->atomic_open() in may_o_create().

Okay.

> > I'm also wondering if you're missing an audit_inode() call in the if
> > (created) path after the retry_lookup label.
> 
> There's no audit_inode() on the created dentry neither in the original
> code nor in the modified code.
> 
> But that may be a bug regardless, it's just independent of my changes.
> At least AFAICS.

Fair enough.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/