Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <87fwaoi9by.fsf@tucsk.pomaz.szeredi.hu>
References: <87fwaoi9by.fsf@tucsk.pomaz.szeredi.hu> <6422.1337872046@redhat.com> <1335357857-16416-1-git-send-email-miklos@szeredi.hu> <7204.1337874722@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: dhowells@redhat.com, viro@ZenIV.linux.org.uk,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        hch@infradead.org, torvalds@linux-foundation.org
Subject: Re: [PATCH 00/16] vfs: atomic open v4 (part 1)
Date: Fri, 25 May 2012 16:20:03 +0100
Message-ID: <13720.1337959203@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 626
Lines: 24

Miklos Szeredi <miklos@szeredi.hu> wrote:

> > Also, does it make sense to combine:
> >
> > 	if (!S_ISREG(nd->inode->i_mode))
> > 		will_truncate = 0;
> >
> > with:
> >
> > 	int will_truncate = open_flag & O_TRUNC;
> >
> > up at the top of the function.
> 
> We need to check nd->inode->i_mode *after* the lookup.  So top of the
> function is not a good place.

Good point.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/